Repository navigation
fix(gateway): warn when a peer gateway's address is in this node's pool - #1606
Merged
Merged
Conversation
kvinwang
enabled auto-merge
November 18, 2026 08:51
Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
force-pushed
the
fix/gateway-warn-pool-overlap
branch
from
November 18, 2026 10:21
5bf985a to
435ea85
Compare
kvinwang
added a commit
that referenced
this pull request
Nov 18, 2026
Import follows #1604: a record carrying any replicated gateway key, or the judging node's own, is rejected as LostConflict on every node. Nodes with equal KV contents now agree once their own keys have replicated; the window before that is kept as a counterexample. Key squatting is added: a counterexample without proof of possession, and stable key binding under the hypothesis that every record was registered by its key's holder (#1615, modeled abstractly). IpAlloc follows #1605: release_ip frees an address only when no other instance holds it. Registration, rebuild, forget and KV reload are modeled, and alloc_ip never reissues a live address, including one a conflict loser shares during its grace period. PoolsClear stays an assumption; #1606 only warns. Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-node agreement on instances assumes no node's client pool contains another node's gateway address, but config validation only sees the local node. When node info is loaded (startup and node changes), warn once per peer whose replicated
wg_ipthis node could hand to a CVM. Log only; nothing is refused and no record format changes. Broadcast and reserved nets of peers are not replicated, so they stay unchecked.From the Lean model of allocation (#1597,
IpAlloc.lean,PoolsClear).